3124: Update the Perforce changelist number once the changelist has been submitted

matt.******@gmai***** (Google Code) (Is this you? Claim this profile.)
Oct. 31, 2013
2272
What version are you running?
1.7.14

What's the URL of the page containing the problem?
http://reviewboard.example.com/r/345

What steps will reproduce the problem?
1. Post a review for changelist 123456 (notice correct Change Number displayed on review)

2. Submit the changelist 123456 which gives output like:

>p4 submit -c 123456
Submitting change 123456.
Locking 1 files ...
Elapsed time: 0.018085
edit //depot/path/to/file.py#4
Change 123456 renamed change 123567 and submitted.


3. Notice that review request still shows Change Number: 123456 instead of 123567.

What is the expected output? What do you see instead?

It would be nice if the review showed the new Change Number 123567.

What operating system are you using? What browser?

Windows 7, Chrome

Please provide any additional information below.

You can use "p4 change -O -o <changelist>" to find the new changelist number for a submitted changelist. This also conveniently works for changelists that have not been renamed such as pending changelists.

In scmtools/perforce.py, in PerforceClient._get_changeset you currently call "p4 describe -s <changesetid>" to get the changeset information. If you instead first call "p4 change -O -o <changesetid>" and parse out the new changelist number you can then call "p4 describe -s" on the new changelist number. You would then need to update PerforceTool.parse_change_desc to set changeset.changenum to the parsed changenum instead of the passed in changenum.
david
#1 david