3068: Click admin "Review board Activity" < > buttons when box is minimized send a crash email.

mique******@gmai***** (Google Code) (Is this you? Claim this profile.)
Dec. 11, 2013
What version are you running?

What's the URL of the page containing the problem?

 'PATH_INFO': u'/reviews/admin/widget-activity/',

What steps will reproduce the problem?
1. Open admin board page with the "Review board activity" box minimized.
2. click "<" or ">" buttons.
3. Review board send an ERROR email to admin with a crash.

Traceback (most recent call last):

  File "/usr/local/lib/python2.6/dist-packages/Django-1.4.6-py2.6.egg/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.7.13-py2.6.egg/reviewboard/admin/views.py", line 137, in widget_activity
    activity_data = dynamic_activity_data(request)

  File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.7.13-py2.6.egg/reviewboard/admin/widgets.py", line 354, in dynamic_activity_data
    new_range_start + datetime.timedelta(days=days_total)

TypeError: coercing to Unicode: need string or buffer, datetime.timedelta found

What is the expected output? What do you see instead?
No crash.

What operating system are you using? What browser?
User OS: Mac 
Browser: Chrome
 'HTTP_USER_AGENT': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/28.0.1500.95 Safari/537.36',
#1 david
  • +PendingReview
  • +david
#2 david
Fixed in release-1.7.x (ca69dfd). Thanks!
  • -PendingReview