3006: When creating new site entered password isn't checked for match

mech*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 8, 2014
What version are you running?

What's the URL of the page containing the problem?
site-create master

What steps will reproduce the problem?
1. run site configuration master
2. go to the password for admin step
3. enter mismatching passwords

What is the expected output? 
System informs you about mismatching passwords, master doesn't proceed, password can be corrected
What do you see instead?
System accepts any data you send, does all the actions, and on the final step reports that your passwords are wrong, and abort installation.

What operating system are you using? What browser?
Debian 6.0, MySQL 5.1, browser independent issue

The same issue you can see in database connection string -- entered data is not verified, and the installation aborts in the middle. 
The best solution here (in my point of view) is to verify data, and, probably, to test the connection before the master ends. I mean, after the database connection parameters is set, the system checks if connection is available, and warn user in case of any errors. Now in case master is failed you should do lots of operations to rollback system to the initial point.
#1 chipx86
Sorry, to clarify, are we talking database passwords?
  • +NeedInfo
#2 mech*****@gmai***** (Google Code) (Is this you? Claim this profile.)
I'm sorry, probably, I'd create 2 separate issues.
I've meant that no entered passwords are checked. The 1st issue I've bumped in was with the reviewboard admin -- I've made a typo, and the system reported about that only in the middle of the installation process, so I had to remove already copied files, and so on. I know that you show entered passwords, but it's more common that system checks passwords for matching, not user.

The 2nd issue I had when I've done a typo in the database password (well, maybe, I should enter texts more slowly =)). In this case master proceeded to the database filling, and notified me that I've made this error. I'm not sure if the installation master is manageable, but anyway I'd be great that user settings were checked before the installation is started.
#3 david
  • -NeedInfo
  • +EasyFix
#4 david
  • +Component-Scripts
#5 david
  • -Component-Scripts
#6 tamijo.f********@gmai***** (Google Code) (Is this you? Claim this profile.)
I will look into this!
#7 david
Fixed in master (0341b58). Thanks!
  • -New