2984: changing comment status when "edit review" before publishing will not update issue_status field

nan****@gmai***** (Google Code) (Is this you? Claim this profile.)
david
david
Aug. 8, 2013
What version are you running?
1.7.6

What's the URL of the page containing the problem?
review editor

What steps will reproduce the problem?
1. create a comment when viewing diff and check "Open an issue" and save this comment
+-----+-------------+--------+--------------+--------------+
| id  | text        | public | issue_status | issue_opened |
+-----+-------------+--------+--------------+--------------+
| 398 | new bug     |      0 | O            |            1 |
+-----+-------------+--------+--------------+--------------+

2. click on "Edit Review" in top green ruban, review editor will appear.
in review editor uncheck "Open an issue" box for the previous comment and save
issue_status remains to "O" and issue_opened moved to 0
+-----+---------+--------+--------------+--------------+
| id  | text    | public | issue_status | issue_opened |
+-----+---------+--------+--------------+--------------+
| 398 | new bug |      0 | O            |            0 |
+-----+---------+--------+--------------+--------------+

3. publish your review,
+-----+---------+--------+--------------+--------------+
| id  | text    | public | issue_status | issue_opened |
+-----+---------+--------+--------------+--------------+
| 398 | new bug |      1 | O            |            0 |
+-----+---------+--------+--------------+--------------+

What is the expected output? 
+-----+---------+--------+--------------+--------------+
| id  | text    | public | issue_status | issue_opened |
+-----+---------+--------+--------------+--------------+
| 398 | new bug |      1 | NULL         |            0 |
+-----+---------+--------+--------------+--------------+

What do you see instead?
+-----+---------+--------+--------------+--------------+
| id  | text    | public | issue_status | issue_opened |
+-----+---------+--------+--------------+--------------+
| 398 | new bug |      1 | O            |            0 |
+-----+---------+--------+--------------+--------------+

What operating system are you using? What browser?
Linux ubuntu 12.04 for server, ubuntu 10.04 + chromium for client

I'm not sure it is safe to keep issue_status != NULL and issue_opened=0
In fact I do not see added value for issue_opened field, maybe there is one?
david
#1 david
  • +Started
  • +david
david
#2 david
Fixed in master (1c98b2c). Thanks!
  • -Started
    +Fixed