2954: Interdiffs include committed changes during review (specifically CVS, but this shouldn't matter)

lamo*****@gmai***** (Google Code) (Is this you? Claim this profile.)
April 16, 2013
311 
What version are you running?
1.7.6

What's the URL of the page containing the problem?
/r/1/diff/1-2/

What steps will reproduce the problem?
1. Post review for changes in sandbox
2. Other users commit changes
3. Update local sandbox and update diff on review
4. View interdiff, includes changes by other users

What is the expected output? What do you see instead?
Only differences between diffs.

What operating system are you using? What browser?
Mac.  Chrome.

Please provide any additional information below.
Is this the expected behavior?  If so, why?

Does it make sense to rely on patchutil's interdiff (assuming the current codebase does not)?  Or re-implement the algorithm used there?

Interdiff is basically non-functional if the users keeps their sandbox up to date.
david
#1 david 
Not including changes that get pulled in from updates is very, very hard. Every so often we circle back around to this problem but nobody's had any ideas yet (and patchutils' interdiff doesn't do what we want).

I know some people will do tricks where they update their checkout, re-post the old diff, then post the new diff, to get a good interdiff. It's not a great solution, but it works.