2950: Reviewboard sometimes shows reverse diff-between-patches

*@vidsol******* (Google Code) (Is this you? Claim this profile.)
Aug. 12, 2013
1486
What version are you running?
1.7.4

What's the URL of the page containing the problem?

https://git.reviewboard.kde.org/r/109846/diff/6-7/


What steps will reproduce the problem?

A fellow user of KDE's reviewboard writes:

if you go to https://git.reviewboard.kde.org/r/109846/diff/6-7/ to see changes between revision 6 and revision 7 of the patch, it looks like 2 new lines were introduced in src/EngineController.h revision 7, compared to revision 6. However, if you check the revisions 6 and 7 alone, you see that the lines were actually removed in r7 compared to r6 - while r6 touched the src/EngineController.h file, r7 doesn't touch it at all. In other words, reviewboard shows the *reverse* diff-between-patches for some files, sometimes.

This happens particularly when revision N touches/introduces a file, while revision N+1 doesn't touch it anymore/ceases to introduce it. This should be reproducible every time.

This is very probably an upstream reviewboard bug, I just rather run it through KDE Systadmins in case they have something to add.
chipx86
#1 chipx86
This is filed upstream, as this is Review Board's support tracker and not KDE's.

There are some issues like this that we need to address. I think we have another bug covering them, but I don't have it handy right now.