2733: Avoid review creation if diff upload fails

sharath.h*********@gmai***** (Google Code) (Is this you? Claim this profile.)
Oct. 19, 2014

What version are you running?

What's the URL of the page this enhancement relates to, if any?

Describe the enhancement and the motivation for it.
When I try a post-commit, it sometimes fails with an the below message.
I would like an option to avoid creating a review ID if the upload fails so that I dont create an ID for every such failures.

Error uploading diff
Your review request still exists, but the diff is not attached.

What operating system are you using? What browser?
Win 7, Chrome

Please provide any additional information below.
#1 david
  • +Component-RBTools
#2 chipx86
  • +Project-RBTools
#3 david
This is quite doable now that we have the diff validation resource.
#4 david
Fixed in release-0.6.x (9b18656). Thanks!
  • +Fixed