2696: "Add comment" missing towards the end of a review
- Fixed
- Review Board
| grossag | |
 |
|
| Oct. 19, 2012 |
What version are you running? 1.6.9 What's the URL of the page containing the problem? https://reviewboard.eng.vmware.com/r/364123/ What steps will reproduce the problem? (Not entirely sure). 1. Write a long review with several comments. 2. Have the author respond to some comments. What is the expected output? What do you see instead? I expect to see "Add Comment" on the review page after every comment thread. However, the last comment thread in a review I gave doesn't have an "Add Comment" button and I didn't already add a comment on that part of the review. What operating system are you using? What browser? Windows 7 Google Chrome 21.0. I can't verify it in IE9 because it won't let me click the "+" buttons on a review page. Please provide any additional information below.
I mentioned IE9 but it actually was IE8. I filed issue 2697 to track that problem.
I think I may have figured out how I did it. I hit "Add Comment" and was adding a comment to a review and then canceled out of it and then the "Add Comment" hyperlink didn't appear again. Some times the hyperlink reappeared and some times it didn't.
This is probably an ajax problem. The "add comment" should re-appear once the server responds. I was unable to reproduce this issue on 1.7b1. Will look further into it.
I can confirm this issue. It is also present in 1.7b1. Steps: 1. Click "Add Comment" 2. Write a comment 3. Hit "Cancel" Output: The "Add Comment" link disappears. Also, RB does not trigger an ajax request in the specific scenario. It does however trigger a request when the body of the comment is empty.
A fix is up for review: http://reviews.reviewboard.org/r/3415/
Fixed on release-1.6.x (56d6934)
-
+ Fixed -
+ Component-Reviews + Milestone-Release1.6.x -
+ chipx86