2671: post-review post commit fails with deletes against SVN

chuck******@gmai***** (Google Code) (Is this you? Claim this profile.)
Oct. 19, 2012
What version are you running?

What's the URL of the page containing the problem?
N/A.  It's a post-review issue

What steps will reproduce the problem?
1. Find and SVN revision (i.e. 508) with a file delete
2. Run "post-review --revision-range=507:508"

What is the expected output? What do you see instead?
I expect to see that a review was created for the specific revisions.  Instead I get the following error:

Failed to execute command: ['svn', 'info', '/tools/TestHarness/lib/ojdbc14.jar']
["svn: warning: W155010: The node '/home/test/trunk/tools/TestHarness/lib/ojdbc14.jar' was not found.\n", '\n', "svn: E200009: Could not display info for all targets because some targets don't exist\n"]

What operating system are you using? What browser?
It happens on both Windows and CentOS.

Please provide any additional information below.
It looks like post-review is trying to do an "svn info" locally on a deleted file and it will obviously get that the target doesn't exist.  I would guess the path should be to the remote file and include the revision number (i.e. svn+ssh://<repository>/<file_path>@<revision>).
#1 chuck******@gmai***** (Google Code) (Is this you? Claim this profile.)
So this works when using the --repository-url option.
#2 michaeldav**********@gmai***** (Google Code) (Is this you? Claim this profile.)
Bump.  Getting the same error with server 1.6.11 and RBTools 0.4.1.
#3 chipx86
  • +Confirmed
  • -Priority-Medium
  • +smacleod
#4 smacleod
patch for review: http://reviews.reviewboard.org/r/3428/
#5 smacleod
Fixed in master (ba3dd45597).
  • -Confirmed