2660: binary data is processed improperly in svn, post-review

nosov.******@gmai***** (Google Code) (Is this you? Claim this profile.)
Sept. 24, 2012
2359
1792
What version are you running?
RB 1.6.3

What's the URL of the page containing the problem?

HTTP POSTing to http://reviews.example.com/api/review-requests/178/diffs/: {'
basedir': '/'}

What steps will reproduce the problem?

1. Say, we have two revisions. On the first revision we created the /trunc directory. On the second revision we put icon.png into it and committed.

The diff will show smth like this:

Index: trunk/icon.png
===================================================================
--- trunk/icon.png	(revision 1)
+++ trunk/icon.png	(revision 2)

Property changes on: trunk/icon.png
___________________________________________________________________
Added: svn:mime-type
## -0,0 +1 ##
+application/octet-stream
\ No newline at end of property

2. Now we try to create a review with post-review.
post-review 


What is the expected output? What do you see instead?

>>> HTTP POSTing to http://reviews.example.com/api/review-requests/176/diffs/: {'basedir': '/'}
>>> Got API Error 207 (HTTP code 400): The file was not found in the repository
>>> Error data: {u'stat': u'fail', u'file': u'/trunk/icon.png', u'err': {u'msg': u'The file was not found in the repository', u'code': 207}, u'revision': u'1'}
Your review request still exists, but the diff is not attached.


What operating system are you using? What browser?
Firefox, Linux

Please provide any additional information below.
The output-diff is as follows:

Index: /trunk/icon.png
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: /trunk/icon.png
===================================================================
--- /trunk/icon.png	(revision 1)
+++ /trunk/icon.png	(revision 2)

Property changes on: trunk/icon.png

It would be ok if the commit contained only binary data, but is also includes text information, so this makes inconvenient to get post-commit reviews when a commit contains added binary data.
#1 nosov.******@gmai***** (Google Code) (Is this you? Claim this profile.)
The second steps is actually:

post-review --revision-range=1:2 -d --publish

Everything works with --revision-range=0:2
#2 nosov.******@gmai***** (Google Code) (Is this you? Claim this profile.)
It seems like a problem of svn 1.7 diff difference to 1.6
#3 huangsha********@gmai***** (Google Code) (Is this you? Claim this profile.)
I meet the same problem. It is OK for text file, but not binary.