2620: Input text field for smtp server address is not stripped from white space

magnus.*******@gmai***** (Google Code) (Is this you? Claim this profile.)
Jan. 19, 2013
What version are you running?
1.6.6

What's the URL of the page containing the problem?
/admin/settings/email/

What steps will reproduce the problem?
1. Input a valid smtp address but add a space after the address
2. Save the configuration
3. Do something that generates an email to be sent (e.g. a new review request)

What is the expected output? What do you see instead?
Expected: Email sent.
Outcome: No email sent. Reviewboard log shows that django smtp.py script fails to open the socket to the host.

What operating system are you using? What browser?
CentOs 6, firefox

Please provide any additional information below.
Stripping a smtp address from white space should happen somewhere along the path done to opening the socket. An address can not contain a white space and still be a valid address.
david
#1 david
  • +EasyFix
david
#2 david
  • +Component-Admin
#3 su***@hakc**** (Google Code) (Is this you? Claim this profile.)
Should be fixed: http://reviews.reviewboard.org/r/3759/
david
#4 david
Pushed to release-1.7.x (e6e5d07). Thanks!
  • +Fixed