2612: Lines moved from here to here - seems to be stuck

aravind********@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
Nov. 18, 2012 
What version are you running?
1.6.6

What's the URL of the page containing the problem?
I discarded the review and do not have the link

What steps will reproduce the problem?
1. Modify a file and move code all around the place.
2. Upload the diff on review board
3. It seems stuck doing something

What is the expected output? What do you see instead?
I expect to see the diff, I instead see that review board is busy with something. 
I recently noticed this feature of reviewboard, that tells us if lines of code were moved around in the file. I changed a file, where I had to move around a lot of code. Maybe the logic is stuck trying to figure out all the lines moved?


What operating system are you using? What browser?
Windows 7, chrome

Please provide any additional information below.
chipx86
#1 chipx86 
So the entry for the diff is just showing a spinner and never doing anything? Can you go into your browser's JavaScript console and see if there are any errors?
  • +NeedInfo
#2 aravind********@gmai***** (Google Code) (Is this you? Claim this profile.) 
I see this: Uncaught ReferenceError: setFileAttachmentComments is not defined
david
#3 david 
Can you get a traceback for that?
david
#4 david
  • -NeedInfo
    +Incomplete
#5 ata****@gmai***** (Google Code) (Is this you? Claim this profile.) 
I ran into this too, submitted a fix...

http://reviews.reviewboard.org/r/4330/
chipx86
#6 chipx86 
Fixed on release-1.6.x, release-1.7.x and master. Thanks for the patch!
  • -Incomplete
    +Fixed
  • +Component-DiffViewer
    +Milestone-Release1.6.x
  • +chipx86