2559: Replying inlne to a review comment should be in direct response to the comment
- Duplicate
- Review Board
| sbre*****@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| Feb. 20, 2013 | |
| 1426 | |
| 2900 |
I assume this must have already been filed, but I couldn't find it anywhere after multiple searches, so opening a new issue. What version are you running? 1.5 What's the URL of the page this enhancement relates to, if any? The diff pages Describe the enhancement and the motivation for it. When clicking on a review comment when viewing a diff, more comments can of course be added. Currently, this always creates an entirely new review. While it should be possible to create a new review, it should also be able to reply to the comment directly as if reading through the review and clicking "Add comment". This way, when it's necessary to go to the diff for context for a given comment (because the reviewer didn't select enough lines with their comment), one does not have to go back to the review to actually write the comment. What operating system are you using? What browser? Win 7 64-bit, FF11 Please provide any additional information below.
Our group has started to adopt reviewboard. Initially we adopted reviewboard with great gusto as it has some excellent features but having gone through a review of project with a diff with ~4000K lines of changes we've noticed some downsides (some of which I'm hoping are because we're just doing things wrong). In the case of this RFE, it's difficult to validate that the suggested changes are made if a new review is created for inline responses to the original comments. Instead the inline comment should be appended to the original review so that at the end you can go back and look at your review and see that all things have been addressed. [ This is on v1.5.1 (which is admittedly a bit behind - the rest of our org had already setup and are using reviewboard) and a mercurial-based gate ]
-
+ Component-Reviews
Merging related issues together.