2552: /api/review-requests/#/diffs/#/files/#/diff-comments/ does not 404 for invalid diff or file ids

smacleod
Oct. 31, 2012 
What version are you running?
1.6.4+ (Probably earlier as well)

What's the URL of the page containing the problem?
/api/review-requests/{valid-request-id}/diffs/{diff-id}/files/{file-id}/diff-comments/ 
Where at least one of diff-id and file-id are invalid.

What steps will reproduce the problem?
1.Visit the URL

What is the expected output? What do you see instead?
This should return a 404, but instead a list of 0 results is returned.

What operating system are you using? What browser?
Ubuntu 11.10, Chrome 18

Please provide any additional information below.
#1 smacleod 
This also occurs with /api/review-requests/{valid-request-id}/diffs/{invalid-diff-id}/files/
david
#2 david
  • +EasyFix
#3 miche.******@gmai***** (Google Code) (Is this you? Claim this profile.) 
Will work on this.
david
#4 david 
Fixed in release-1.6.x (7c4c0ce). Thanks!
  • +Fixed