What version are you running?
RBTools 0.4
What's the URL of the page containing the problem?
N/A
What steps will reproduce the problem?
1. Call post-review with --username and --password.
What is the expected output? What do you see instead?
post-review fails with "Authentication information needs to be provided on the command line when using --diff-filename=-".
This exit path is incorrectly taken because the check at the beginning of the login() function has an operator precedence bug. It should be
if (options.diff_filename == '-' and
not (self.has_valid_cookie() or
(options.username and options.password))):
