post-review from RBTools-0.3.4 crashes when commit contains a property change on a directory, for example:
# svn diff -c 82 file:///var/svn/repos/startyco/
Index: site/answers/tpl
===================================================================
--- site/answers/tpl (revision 81)
+++ site/answers/tpl (revision 82)
Property changes on: site/answers/tpl
___________________________________________________________________
Added: svn:ignore
## -0,0 +1 ##
+templates_c
Observe in the review board log:
2011-12-27 14:17:34,816 - DEBUG - DiffParser.parse: Beginning parse of diff, size = 320
2011-12-27 14:17:34,816 - DEBUG - DiffParser.parse: Finished parsing diff.
2011-12-27 14:17:34,821 - ERROR - Error uploading new diff: URL 'file://var/svn/startyco/site/answers/tpl' refers
to a directory
Can't get text contents of a directory
Traceback (most recent call last):
File "/usr/lib/python2.6/site-packages/reviewboard/webapi/resources.py", line 1132, in create
request.FILES.get('parent_diff_path'))
File "/usr/lib/python2.6/site-packages/reviewboard/reviews/forms.py", line 250, in create
history)
File "/usr/lib/python2.6/site-packages/reviewboard/diffviewer/forms.py", line 63, in create
diff_file, basedir, check_existance=(not parent_diff_file)))
File "/usr/lib/python2.6/site-packages/reviewboard/diffviewer/forms.py", line 149, in _process_files
not tool.file_exists(filename, revision))):
File "/usr/lib/python2.6/site-packages/reviewboard/scmtools/core.py", line 68, in file_exists
self.get_file(path, revision)
File "/usr/lib/python2.6/site-packages/reviewboard/scmtools/svn.py", line 146, in get_file
raise SCMError(e)
SCMError: URL 'file://var/svn/startyco/site/answers/tpl' refers to a directory
Can't get text contents of a directory