2389: Incorrect web interface styling when using parent diffs and new files

daniel*******@gmai***** (Google Code) (Is this you? Claim this profile.)
Sept. 29, 2012
What version are you running?
1.6 RC2

What's the URL of the page containing the problem?
It's an internal database so this is N/A

What steps will reproduce the problem?
1. In a test git repo with reviews managed in RB:
2. create a new file with arbitrary content (echo >my_file 'hello')
3. add and commit that file to the repo (git add my_file ; git commit -m "added a file")
4. modify the same file (echo >my_file 'bye bye')
5. commit the second change to the repo (git add my_file ; git commit -m "modified a file")
6. Create a parent diff from the first change (git diff HEAD~2 HEAD~1 >parent.diff)
7. Create a diff for the modification (git diff HEAD~1 HEAD >main.diff)
8. Create a review request against the repo using the parent diff and diff you just created
9. Click 'view diff'

What is the expected output? What do you see instead?
I expected the diff to be displayed as a 'changed file' but it is displayed as a 'new file'; the resulting styling causes the left pane to be of fixed size.

What operating system are you using? What browser?
Windows 7 Enterprise, FF8.0 & IE 8.0.7600.16385

Please provide any additional information below.
This bug is not fatal but in certain circumastances it can make it very awkward to view diffs; using firebug to remove the 'newfile' style from that diff view corrects this, but this is just a hack.
#1 chipx86
We're just not being careful when applying the styles. We need to take more into account when doing this.
  • +Confirmed
  • +EasyFix
#2 tinay******@gmai***** (Google Code) (Is this you? Claim this profile.)
I'll look into this.
#3 david
Fixed in release-1.6.x (bbcbebe). Thanks!
  • -Confirmed