2271: Include review ID in subject line of generated emails
- Fixed
- Review Board
| sudhir.********@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| Jan. 27, 2012 |
http://reviews.reviewboard.org/ What version are you running? RB 1.6.1 What's the URL of the page this enhancement relates to, if any? Not related to URL. Describe the enhancement and the motivation for it. Right now it says “Review request: blah bhah” but it would be nice if the id was mentioned too. E.g. “Review request 227: blah blah”. What operating system are you using? What browser? Multiple operating system Please provide any additional information below.
Our RB code has been tweaked to get this feature. Below is the change. sudhirbs@wlan-rb notifications $ diff email.py.orig email.py 258c258 < subject = u"Review Request: %s" % review_request.summary --- > subject = u"Review Request %d : %s" % (review_request.id, review_request.summary) 308c308 < u"Re: Review Request: %s" % review_request.summary, --- > u"Re: Review Request %d : %s" % (review_request.id, review_request.summary), 343c343 < u"Re: Review Request: %s" % review_request.summary, --- > u"Re: Review Request %d : %s" % (review_request.id, review_request.summary),
Feature added for code review at: http://reviews.reviewboard.org/r/2823/
Thanks David for incorporating this feature into official code. Regards Sudhir
What was the reason to add this? There's no way to disable it and it made email subjects mostly useless. People can still search the review id in the body of the email without this change, are there plans to make it optional (or the entire subject customizable)?
Well, this is something that happened a long, long time ago, so my memory is a little hazy, but basically our reasoning was that we observed people using the review request IDs more and more to communicate with each other (in the same way that people refer to bug numbers). It adds 4-6 characters to the subject, which I think hardly makes it "useless"--even on mobile email clients I can still see the summary of the review request in the subject lines.
I realized after I posted that it was so old, sorry to be late to the party (we just upgraded :). What I see in Mail.app's sidebar (default window size) is "Review Request: <number> <word>..." where <word> sometimes barely helps identify the package name. If it was up to me I'd just add a "Review:" prefix (or maybe "Reviewboard"): the "Request" word is kind of redundant and it ends up titling review "responses" as well, and the number is searchable through the rest of the email since it's in the URL. If you really want to keep the number "Review <number>" would be easier to manage, or even better a way to customize subjects in the settings.