2250: Modfying a review reply doesn't update itself but submits another new review reply.

kzha****@gmai***** (Google Code) (Is this you? Claim this profile.)
Aug. 21, 2011
What version are you running?


What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. Create a new review reply and press 'OK' to send it to a server.
2. Click 'pencil' icon to edit the review reply again.
3. Press 'OK' and save it again. (Here we don't see any problems.)
4. Publish the pending replies.
5. Now we see two review replies, one is before re-edit and one is after re-edit.

What is the expected output? What do you see instead?

Show only the last result.

What operating system are you using? What browser?

Ubuntu 8.04.
It happens on Chrome and Firefox.

Please provide any additional information below.

As I saw requests to a server via 'firebug', it seems that the 'comment id' is inclemented always when I pressed 'OK'.
#1 chipx86
This was a known bug in RC1, but was fixed, and we've seen no more reports of it. Are you certain you ran 'rb-site upgrade' on the site and restarted your web server?
  • +NeedInfo
#2 kzha****@gmai***** (Google Code) (Is this you? Claim this profile.)
Thank you for your comment. 

I'm sure that I ran 'rb-site upgrade' because reviewboard complains to me after updating to 1.6rc2 from 1.5.

I want to double-check the changes you made is correctly applied to our site. 
Could you tell me the changeset which should correct it?
I cannot find it in the release note of 1.6rc2.

Thank you for your cooperation.
#3 chipx86
My apologies, this was fixed right after RC2. So it will be in the final release.

You can grab a 1.6 nightly, which will include this fix.
#4 kzha****@gmai***** (Google Code) (Is this you? Claim this profile.)
!! I've just fished checking the commits on github. And, you're right. 
I'll grab the nightly and give it a try.

Thank you for your quick response and great software!