2194: review counts in the left column of the dashboard are broken

plu***@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
Aug. 1, 2011
2197 
What version are you running?

1.6RC2

What's the URL of the page containing the problem?

dashboard

What is the expected output? What do you see instead?

See the attached screenshot. Most of the counts are correct, but "Outgoing Reviews", "Incoming Reviews", and "All My Requests" are wrong.

What operating system are you using? What browser?

The server is CentOS 5.6 with python 2.4. The browser is Firefox 5 on Fedora 15.

As an aside, I get a syntax error in perforce.py. I'll submit another bug on that issue when I can properly reproduce it (this is a production system, so I need to try it on a test system), but perhaps 1.6 doesn't work well with python 2.4? Just an idea...

Please provide any additional information below.

There's nothing in the error log. How else can I help diagnose this? Is there a way to turn SQL tracing on, or something?
#1 plu***@gmai***** (Google Code) (Is this you? Claim this profile.) 
I forgot to attach the screenshot, sorry.
chipx86
#2 chipx86
  • +Confirmed
  • -Priority-Medium
    +Priority-Critical
    +Milestone-Release1.6
    +Component-Dashboard
  • +chipx86
chipx86
#3 chipx86
chipx86
#4 chipx86 
I need a repro case for this. What actions, exactly, cause the count to become wrong? I need to know how to take it from 0 (as in, no review requests) to -1.
  • -Confirmed
    +NeedInfo
#5 plu***@gmai***** (Google Code) (Is this you? Claim this profile.) 
This was on an upgrade, a server with tens of thousands of reviews. I'll see if I can get a clone of the VM tomorrow and then I can play around with it.
#6 plu***@gmai***** (Google Code) (Is this you? Claim this profile.) 
Oh, as an aside, it's happening to a lot of people. I can't say for sure that it's everyone, but at least six or seven people have mentioned it to me. Also, note that the "All My Requests" is wrong as well. I should have a thousand or so review requests... The group counts are probably correct, though. I don't know about Starred Reviews because I don't use that feature.

Anyway, just some more data. I'll try to look into it more soon if you don't have any immediate ideas.
chipx86
#7 chipx86 
I have some repro cases I managed to make. I have a fix for some of it.
  • -NeedInfo
    +Started
chipx86
#8 chipx86
  • -Started
    +PendingReview
chipx86
#9 chipx86 
Fixed on master (94e5004)
  • -PendingReview
    +Fixed