eri***@gmai***** (Google Code)

2002: linkified URL has succeeding parenthesis included in link's target URL

eri***@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
chipx86
Sept. 29, 2012
2038
What version are you running?

1.5.2

What's the URL of the page containing the problem?

private reviewboard install

What steps will reproduce the problem?
1. Add "(someurl)" to a comment on the Reviews page.
2. Look at the review and notice that the ) has been included into the URL itself; i.e., it is underlined and when you click the link it heads to "someurl)" instead of "someurl".

What is the expected output? What do you see instead?

I expected to have a linkified/clickable URL embedded in the comment text with parentheses around it, but not included into the URL itself. 

What operating system are you using? What browser?

Server OS: Ubuntu 9.04 x86_64
Browser: Chrome 9.0.597.102

Please provide any additional information below.
chipx86
#2 chipx86
  • +Confirmed
  • -Priority-Medium
    +Priority-Low
    +Milestone-Release1.6
    +Component-Reviews
chipx86
#3 chipx86
  • +EasyFix
chipx86
#4 chipx86
Fixed on master (2684c32)
  • -Confirmed
    +Fixed
  • +chipx86
sbre*****@gmai***** (Google Code)
#5 sbre*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Thanks for fixing!

You might actually want to only exclude the final parenthesis if there's no previously unclosed open parenthesis, particularly if it immediately precedes the close parenthesis. That way, at least links like the follow would still work:

http://download.oracle.com/javase/1.4.2/docs/api/java/lang/Object.html#clone()
http://download.oracle.com/javase/1.4.2/docs/api/java/lang/Object.html#equals(java.lang.Object)
chipx86
#6 chipx86
That's a good point, and should be easy to take care of.
  • -Fixed
    +Confirmed
chipx86
#7 chipx86
  • -Milestone-Release1.6
    +Milestone-Release1.6.x
john.******@gmai***** (Google Code)
#8 john.******@gmai***** (Google Code) (Is this you? Claim this profile.)
Having a look at this, with regards to the sbress's comment.
john.******@gmai***** (Google Code)
#9 john.******@gmai***** (Google Code) (Is this you? Claim this profile.)
http://reviews.reviewboard.org/r/3374/
Ship it! Fixed, though not "perfect" solution, should cover most cases.
david
#10 david
Fixed in master (28878fc). Thanks!
  • -Confirmed
    +Fixed
john.******@gmai***** (Google Code)
#11 john.******@gmai***** (Google Code) (Is this you? Claim this profile.)
Ship it was given on the reviewboard.