1987: Summary containing newline fails to send email

adj***@gmai***** (Google Code) (Is this you? Claim this profile.)
March 21, 2011
1689
What version are you running?


What's the URL of the page containing the problem?


What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


What operating system are you using? What browser?


Please provide any additional information below.
ERROR:root:Error sending e-mail notification with subject 'Re: Review Request:summary with a
new line' on behalf of '"xyz" <xyz@xxx.com>' to '"a" <a@b.jp>,"p" <g@c.jp>': Header values can't contain newlines (got u'Re: Review Request: summary with a \n newline' for header 'Subject')
Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/ReviewBoard-1.5.3.1-py2.5.egg/reviewboard/notifications/email.py", line 177, in send_review_mail
    message.send()
  File "/usr/lib/python2.5/site-packages/Django-1.2.3-py2.5.egg/django/core/mail/message.py", line 175, in send
    return self.get_connection(fail_silently).send_messages([self])
  File "/usr/lib/python2.5/site-packages/Django-1.2.3-py2.5.egg/django/core/mail/backends/smtp.py", line 85, in send_messages
    sent = self._send(message)
  File "/usr/lib/python2.5/site-packages/Django-1.2.3-py2.5.egg/django/core/mail/backends/smtp.py", line 101, in _send
    email_message.message().as_string())
  File "/usr/lib/python2.5/site-packages/ReviewBoard-1.5.3.1-py2.5.egg/reviewboard/notifications/email.py", line 93, in message
    msg = super(SpiffyEmailMessage, self).message()
  File "/usr/lib/python2.5/site-packages/Django-1.2.3-py2.5.egg/django/core/mail/message.py", line 145, in message
    msg['Subject'] = self.subject
  File "/usr/lib/python2.5/site-packages/Django-1.2.3-py2.5.egg/django/core/mail/message.py", line 96, in __setitem__
    name, val = forbid_multi_line_headers(name, val, self.encoding)
  File "/usr/lib/python2.5/site-packages/Django-1.2.3-py2.5.egg/django/core/mail/message.py", line 62, in forbid_multi_line_headers
    raise BadHeaderError("Header values can't contain newlines (got %r for header %r)" % (val, name))
BadHeaderError: Header values can't contain newlines (got u'Re: Review Request: summary with a newline' for header 'Subject')
chipx86
#1 chipx86
What are you doing that's causing a newline to appear?
  • +NeedInfo
#2 adj***@gmai***** (Google Code) (Is this you? Claim this profile.)
when a review covers several commits, and I use post-review's --guess-summary option, it generates a summary with all commit summaries separated by newlines
david
#3 david
  • -NeedInfo
    +New
david
#4 david