1976: Error when trying to update a review

matt.******@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 19, 2011
What version are you running?

Review Board 1.5.3
Tried both RBTools 0.3 and 0.3.1

What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. post-review 4438701 (This successfully posts the review.)
2. (Make some changes to files in the Perforce changelist.)
3. post-review 4438701 (This fails.)

The crash happens regardless of whether I publish the first draft or not.

What is the expected output? What do you see instead?

Expected a successfully posted review, instead got:
Error creating review request: One or more fields had errors

What operating system are you using? What browser?

The post-review command is run on Win 7 x64.
The Review Board server is running RHEL 5.5.

Please provide any additional information below.

Attached is post-review -d output for the first (successful) post and the second (failed) post.
P:\MyDepot>post-review -d 4438701
>>> RBTools 0.3
>>> Home = C:\Users\mmulsow\AppData\Roaming
>>> svn info
>>> p4 info
>>> repository info: Path: perforce.example.com:1666, Base path: None, Supports changesets: True
>>> Generating diff for changenum 4438701
>>> p4 describe -s 4438701
>>> Processing edit of //MyDepot/myFile.txt
>>> Writing "//MyDepot/myFile.txt#41" to "c:\users\mmulsow\appdata\local\temp\tmpoptiu8"
>>> p4 print -o c:\users\mmulsow\appdata\local\temp\tmpoptiu8 -q //MyDepot/myFile.txt#41
>>> diff -urNp c:\users\mmulsow\appdata\local\temp\tmpoptiu8 p:\MyDepot\myFile.txt
>>> HTTP GETting api/
>>> HTTP GETting http://review-board.example.com/api/info/
>>> Using the new web API
>>> Attempting to create review request on perforce.example.com:1666 for 4438701
>>> HTTP POSTing to http://review-board.example.com/api/review-requests/: {'changenum': '4438701', 'repository': 'perforce.example.com:1666'}
>>> Review request created
>>> Uploading diff, size: 60
>>> H
#1 chipx86
Not sure which side this is on (RB or RBTools) but we'll look into getting a fix out soon.
  • +Confirmed
  • +Component-RBTools
  • +chipx86
#3 chipx86
Committed a workaround in RBTools (5d9fa34d63c12d54ffeb8cf03cdd7e7b878474d4). I'll be doing a release shortly.

The actual API fix in Review Board will be in a 1.5.3 release, but that won't be out immediately. This shouldn't affect you if you upgrade RBTools though.
  • -Priority-Medium
#4 chipx86
  • -Confirmed