1972: RBTools 0.3 deprecated API can't update existing review

douglas*******@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 7, 2011
What version are you running?

RBTools 0.3
ReviewBoard 1.5.1
(SCM is Perforce)

What's the URL of the page containing the problem?

What steps will reproduce the problem?
1. create a review request
2. Attempt to update request with post-review

What is the expected output? What do you see instead?

400 error is produced rather than the update being submitted.

post-review isn't able to download the previous review, because
a %s substitution isn't performed.

Please provide any additional information below.

Patch to fix RBTools:

index c977908..c920f7e 100755
--- a/rbtools/postreview.py
+++ b/rbtools/postreview.py
@@ -670,7 +670,7 @@ class ReviewBoardServer(object):
         Returns the review request with the specified ID.
         if self.deprecated_api:
-            url = 'api/json/reviewrequests/%s/'
+            url = 'api/json/reviewrequests/%s/' % (rid)
             url = '%s%s/' % (
                 self.root_resource['links']['review_requests']['href'], rid)
#1 chipx86
Thanks for the report. We'll get a release out probably this weekend.
  • +Confirmed
  • -Priority-Medium
  • +chipx86
#2 chipx86
Fixed on master (1141d1e54efdacf87ce3b19f4d67e179a22caf03). Release pending.
  • -Confirmed