1964: Enhance filter possibilities for reviewboard emails

Goli*****@gmai***** (Google Code) (Is this you? Claim this profile.)
March 21, 2011
http://reviews.reviewboard.org/


What version are you running?
1.5.2

Describe the enhancement and the motivation for it.
Hi,

A user of the kde reviewboard had a wish for a feature enhancement. Here is his description along with a "pseudo patch".

---
Hi,

as we now have new headers for the commit mails that enable great filtering I
would like to request that the mails from reviewboard contains a header with
the name(s) of the groups that a request belongs to.

---<somewhat psudo patch>---
diff --git a/reviewboard/notifications/email.py
b/reviewboard/notifications/email.py
index 4665479..d65f44f 100644
--- a/reviewboard/notifications/email.py
+++ b/reviewboard/notifications/email.py
@@ -190,6 +190,7 @@ def send_review_mail(user, review_request, subject,
in_reply_to,
     headers = {
         'X-ReviewBoard-URL': base_url,
         'X-ReviewRequest-URL': base_url + review_request.get_absolute_url(),
+        'X-ReviewGroup' : review_request.target_groups
     }

     sender = None
----------

/Regards
Torgny
chipx86
#1 chipx86
I'd be fine with this. It'd help if someone would take this, turn it into a real patch (should be easy) and then put it on http://reviews.reviewboard.org/.
  • +Confirmed
  • +EasyFix
    +Component-EMail
#2 s.svi*****@gmai***** (Google Code) (Is this you? Claim this profile.)
submitted patch http://reviews.reviewboard.org/r/2204/
david
#3 david
Fixed in master (1.6) as 2383b5c.
  • -Confirmed
    +Fixed