1937: Intellij patch cannot be uploaded into reviewboard

martin******@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
Feb. 20, 2011 
What version are you running?

1.5

What's the URL of the page containing the problem?



What steps will reproduce the problem?
1. create a patch file with Intellij
2. create a new review request and attempt to upload patch file

What is the expected output? What do you see instead?

review should be created. Instead page shows unexpected error message.



What operating system are you using? What browser?

effects all browsers. server side issue 

Please provide any additional information below.

Problem is that the format of the patch created by intellij is not supported by review board

i.e. the working copy is denoted as '(revision )'

Index: src/resources/SqlMapConfig.xml
===================================================================
--- src/resources/SqlMapConfig.xml	(revision 178443)
+++ src/resources/SqlMapConfig.xml	(revision )

temporary local fix by modifying  reviewboard/scmtools/svn.py
 
  def parse_diff_revision(self, file_str, revision_str):
        if revision_str == "(working copy)":
            return file_str, HEAD

        if revision_str == "(revision )":
            return file_str, HEAD
chipx86
#1 chipx86 
It'd be better to do something like:

    if revision_str in ("(working copy)", "(revision )"):

and then document each version in a comment preceding it.

Probably, though, IntelliJ should be patched to be compliant, as they're generating an incorrect diff.

If you have time to make a patch with a unit test for RB, we'll get it into the next point release.
  • +NeedInfo
  • +Milestone-Release1.5.x
    +Component-DiffParser
    +Component-SCMTools
chipx86
#2 chipx86 
Fixed on release-1.5.x and master. This will be in 1.5.4.
  • -NeedInfo
    +Fixed
  • +chipx86