1870: base path does not work with svn-hook-postcommit-review

Xom***@gmai***** (Google Code) (Is this you? Claim this profile.)
Nov. 29, 2010
I realize this is a contributed script and probably isn't all that supported but the base path parameter in /contrib/tools/svn-hook-postcommit-review is not functioning.

I get an error from post-review showing that it included the quotes in the paths it passed to svn diff and other commands (forgot to copy/paste).

I attached a patch to not pass the quotes to those commands (first time creating a git patch).
 contrib/tools/svn-hook-postcommit-review |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/tools/svn-hook-postcommit-review b/contrib/tools/svn-hook-postcommit-review
index 4612ebf..1494a54 100644
--- a/contrib/tools/svn-hook-postcommit-review
+++ b/contrib/tools/svn-hook-postcommit-review
@@ -178,7 +178,7 @@ def main():
     # check for an explicitly-provided base path (must be contained
     # within quotes)
-    m = re.search(r'base ?path:([\'"][^\'"]+[\'"])', log, re.M | re.I)
+    m = re.search(r'base ?path:[\'"]([^\'"]+)[\'"]', log, re.M | re.I)
     if m:
         base_path = m.group(1)
#1 chipx86
Thanks. Can you post this up on http://reviews.reviewboard.org/? We don't do patch review on the bug tracker.
  • +Component-Scripts
#2 Xom***@gmai***** (Google Code) (Is this you? Claim this profile.)
Submitted http://reviews.reviewboard.org/r/1875
#3 david
Fixed in master as e28acf0.
  • +Fixed