1862: reviewboard running patch against empty files

scot*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Oct. 8, 2011 
What is the problem?
Reviewboard is running patch against empty file(s) causing forked process to sleep waiting for input.

What version are you running?
Stable 1.5

What's the URL of the page containing the problem?
Not sure, most likely review page with diff.

What steps will reproduce the problem?
1. touch /tmp/1-new /tmp/1
2. patch -o /tmp/1-new /tmp/1

What operating system are you using? What browser?
Linux 2.6, RHEL5.4 x86_64

Please provide any additional information below.
$ ps ax | grep [p]atch
12701 ?        S      0:00 patch -o /tmp/reviewboard.tTK8b4/tmpd9XDhV-new /tmp/reviewboard.tTK8b4/tmpd9XDhV
12702 ?        S      0:00 patch -o /tmp/reviewboard.FgJfUi/tmpc03lfo-new /tmp/reviewboard.FgJfUi/tmpc03lfo
12703 ?        S      0:00 patch -o /tmp/reviewboard.u2QOpe/tmpO6NOTd-new /tmp/reviewboard.u2QOpe/tmpO6NOTd
13496 ?        S      0:00 patch -o /tmp/reviewboard.g2wQDt/tmpHeiBNY-new /tmp/reviewboard.g2wQDt/tmpHeiBNY
13497 ?        S      0:00 patch -o /tmp/reviewboard.E_I1If/tmpuB2hxE-new /tmp/reviewboard.E_I1If/tmpuB2hxE
15142 ?        S      0:00 patch -o /tmp/reviewboard.al3iUL/tmpIUo9GD-new /tmp/reviewboard.al3iUL/tmpIUo9GD
15143 ?        S      0:00 patch -o /tmp/reviewboard.8vqdLL/tmpZBiuIY-new /tmp/reviewboard.8vqdLL/tmpZBiuIY
15144 ?        S      0:00 patch -o /tmp/reviewboard._aEgqp/tmp2T2Mq8-new /tmp/reviewboard._aEgqp/tmp2T2Mq8
15145 ?        S      0:00 patch -o /tmp/reviewboard.CP_FrE/tmpCJNp1z-new /tmp/reviewboard.CP_FrE/tmpCJNp1z

$ ls -la /tmp/reviewboard.tTK8b4/tmpd9XDhV-new /tmp/reviewboard.tTK8b4/tmpd9XDhV
-rw------- 1 $user $group 0 Oct 22 05:13 /tmp/reviewboard.tTK8b4/tmpd9XDhV
-rw------- 1 $user $group 0 Oct 22 18:44 /tmp/reviewboard.tTK8b4/tmpd9XDhV-new

$ gdb /usr/bin/patch --pid=12701
...
(gdb) bt
#0  0x00000032296c5f00 in __read_nocancel () from /lib64/libc.so.6
#1  0x000000322966b853 in _IO_file_xsgetn_internal () from /lib64/libc.so.6
#2  0x0000003229661c82 in fread () from /lib64/libc.so.6
#3  0x000000000040baef in ?? ()
#4  0x00000000004062e4 in ?? ()
#5  0x000000322961d994 in __libc_start_main () from /lib64/libc.so.6
#6  0x0000000000401c49 in ?? ()
#7  0x00007fff7bb4f968 in ?? ()
#8  0x0000000000000000 in ?? ()
david
#1 david
  • +Component-DiffViewer
david
#2 david 
What type of repository are you using? Is there anything in the logs?
  • +NeedInfo
#3 nai****@gmai***** (Google Code) (Is this you? Claim this profile.) 
I've got what appears to be the same issue with an install of 1.5.6.  We were having the same issue under the old 1.5rc install, which was what prompted the upgrade.

I have debug logs going, but see nothing unusual.

The repository we're using is Perforce.  

I can spin up a new report if you'd prefer.
david
#4 david 
Fixed in master (e15c208). This will ship in 1.7
  • -NeedInfo
    +Fixed