What version are you running? RBTools 0.2 What's the URL of the page containing the problem? NA What steps will reproduce the problem? 1.Clone a http or https repo using git with a username in the repo url 2.Git repo on the reviewboard server lacks username in field. 3.post-review doesn't strip username from url 4.post-review gives error The repository path "https://firstname.lastname@example.org/path/to/projectrepo.git" is not in the list of known repositories on the server. What is the expected output? What do you see instead? Needs to strip username from the url field.
Hi Ben, Can you put this up on http://reviews.reviewboard.org/? All patches should go there to be reviewed. Thanks!
Still working on this , I went ahead and fixed it for ssh,ftp,ftps,https,http. I will be uploading a new diff in a bit. There should be an option to set reviewboard repo url, since there are multiple ways to access the same repo. In are env you can access it via https,ssh, and reviewboard accesses it via file:// but that would be an enhancement and another ticket, so I am going to have a remove_username method , I have written a rather extensive test case using the git clone manual , and did all the ones that might have username Except scp
The latest attached patch from http://reviews.reviewboard.org/r/1771/diff/ solved my issues. with the latest postreview.py code from the rbtools github repository. it would be great if this patch went into the next version of rbtools.
The upcoming RBTools 0.3.1 release (especially combined with the upcoming Review Board 1.5.3) fixes this by allowing .reviewboardrc to specify a REPOSITORY= field, which can be an ID, a path, or (if using 1.5.3) the actual displayed name of the repository.
- Confirmed + Fixed