1795: using "--submit-as" with post-review causes generated mails to be from original submitter

edg****@gmai***** (Google Code) (Is this you? Claim this profile.)
david
 david
Aug. 12, 2013 
What version are you running?
1.0.9

What steps will reproduce the problem?
1. Call post-review with the --submit-as <someone-else> option.

What is the expected output? What do you see instead?
I expect for the RB generated emails to have <someone-else> be the sender, rather than the account which post-review was authenticated with.
david
#1 david
  • +Component-RBTools
#2 christia********@iath**** (Google Code) (Is this you? Claim this profile.) 
I can confirm that. I see the same problem here.

RBTools 0.3.2
#3 micha******@gmai***** (Google Code) (Is this you? Claim this profile.) 
Is this a post-review issue?  We run RB 1.5 beta 2, and see the same behavior.
But the submitter in the review request is indeed the specified user (with correctly resolved e-mail address).  But even later reviews to this request will never copy that submitter.

Is it possible, that there is a general issue with the submitter of a review request being left out from notifications?
chipx86
#4 chipx86 
It's part RBTools, part Review Board. But not really a bug, per se.

--submit-as is used for the creation of a review request, to put it in someone else's name. That's a separate operation from publishing. When publishing, the e-mail will go out as the user logged in.

There's definitely a use case for making a publish operations happen on behalf of another user, but we aren't set up for that today. So this would need to be added.

One option is to just use the review request submitter for the e-mail, but that's likely not what we want in all cases. I'm hoping to introduce a multi-user workflow for review requests, where the ownership can be reassigned, and other users could modify fields with state being preserved to indicate who made the change.

That won't solve your problem directly, though. You'd still need to either log in as the user, or would need to specifically do a --submit-as on that operation (which we'd have to support).
  • -Type-Defect
    +Type-Enhancement
    +Component-EMail
#5 wa***@meetu***** (Google Code) (Is this you? Claim this profile.) 
Just upgraded to 1.7.7.1 from 1.6.2 and we are seeing this issue
david
#6 david
  • +Started
  • +david
david
#7 david 
Fixed in release-1.7.x (8cc0f4d).
  • -Started
    +Fixed