1683: PendingDeprecationWarning while rbsite install

Jan.Ko*******@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
June 27, 2010 
What version are you running?
ReviewBoard 1.5 beta 2

What steps will reproduce the problem?
1. rb-site install newrb
2. Go to the last step
3. Watch screen

There is errors:

/usr/lib/python2.5/site-packages/Django-1.2.1-py2.5.egg/django/db/__init__.py:18: PendingDeprecationWarning: settings.DATABASE_* is deprecated; use settings.DATABASES instead.
  PendingDeprecationWarning
/usr/lib/python2.5/site-packages/Django-1.2.1-py2.5.egg/django/db/__init__.py:57: PendingDeprecationWarning: Short names for ENGINE in database configurations are deprecated. Prepend default.ENGINE with 'django.db.backends.'
  PendingDeprecationWarning
/usr/lib/python2.5/site-packages/Django-1.2.1-py2.5.egg/django/db/models/fields/subclassing.py:71: PendingDeprecationWarning: A Field class whose get_db_prep_value method hasn't been updated to take `connection` and `prepared` arguments.
  setattr(new_cls, attr, call_with_connection_and_prepared(getattr(new_cls, attr)))
/usr/lib/python2.5/site-packages/Django-1.2.1-py2.5.egg/django/db/models/fields/subclassing.py:69: PendingDeprecationWarning: A Field class whose db_type method hasn't been updated to take a `connection` argument.
  setattr(new_cls, attr, call_with_connection(getattr(new_cls, attr)))
/usr/lib/python2.5/site-packages/Django-1.2.1-py2.5.egg/django/db/models/fields/subclassing.py:69: PendingDeprecationWarning: A Field class whose get_db_prep_save method hasn't been updated to take a `connection` argument.

What operating system are you using? What browser?
Linux Debian stable
Python2.5.2
chipx86
#1 chipx86 
We should see about turning off these warnings (if we can), but we can't fix the core issue until we bump our dependency on Django to 1.2 (since we must use the 1.1-compatible settings for databases).

If we ship this, though, that's not the end of the world.

There are two things to tackle here, though. It looks like it's complaining about the old database settings variables, and also about some Field classes not taking the connection argument. The latter is easily fixed (it's a Djblets thing).
  • +Confirmed
  • -Priority-Medium
    +Priority-Low
    +Milestone-Release1.5
    +Component-RB-Site
chipx86
#2 chipx86 
Well, looks like we can't do much about the warnings in this release. In order to really support 1.1 *and* 1.2, we need get_type and get_db_prep_save to take *args, **kwargs instead of just a connection, but that won't silence the warning due to how they check for it. So, for the time-being, we'll need to silence those warnings.
chipx86
#3 chipx86 
Changed rb-site to silence this warning.

Fixed on master (revision 3028465).
  • -Confirmed
    +Fixed
  • +chipx86