1644: ClearCase malformed diff after patching Python difflib

Jan.Ko*******@gmai***** (Google Code) (Is this you? Claim this profile.)
April 4, 2011
What version are you running?
ReviewBoard master branch

What's the URL of the page containing the problem?
post-review script

What steps will reproduce the problem?
0. Patch difflib Python library [http://bugs.python.org/issue2142]
1. Create two similar files without new line at end of file
2. Make post-review diff
3. You get malformed diff

What is the expected output? What do you see instead?
Diff the same as from "diff -u a b" command

What operating system are you using? What browser?

Please provide any additional information below.
Interesting thing that workaround from post-review doesn't work everytime
because sometimes "\ No new line at end of file" must be add twice.
Example: http://bugs.python.org/issue2142
#1 Jan.Ko*******@gmai***** (Google Code) (Is this you? Claim this profile.)
I have one line which looks like:
int abc ;^M  // some variable

and I get malformed diff for revision where this line was add. How I can avoid problem with this line?

#2 david
  • +Component-RBTools
#3 david
Fixed in reviewboard 7553ec1 and rbtools 47fb2ce. Thanks!
  • +Fixed