1620: side by side diffs, extra whitespace at end of line is never highlighted, but should be.

cki***@mindspr******* (Google Code) (Is this you? Claim this profile.)
May 21, 2010
What version are you running?

What's the URL of the page containing the problem?

What steps will reproduce the problem?
1. ensure show white space is selected for side by side difss 

What is the expected output? What do you see instead?
spaces at end of lines should show as highlighted 
instead only interline white space changes are highlighted

What operating system are you using? What browser?
Linux, Firefox 3.

Please provide any additional information below.
The ew class tag for white space changes is present, but not
styled in any way so it does not show in the browser. It should
probably show as a red background which is a common way to
display white space changes in other code review tools.
#1 chipx86
Sounds like a regression. This has always worked before.
  • -Priority-Medium
#2 chipx86
Can you check your admin UI's Diff Viewer settings page and make sure that "Show
trailing whitespace" is checked? It's working fine here. It looks like it may be
disabled, which is concerning.
  • +NeedInfo
#3 chipx86
Nevermind, figured it out.

Fixed on master (c889571)
  • -NeedInfo
  • +Component-DiffViewer
  • +chipx86