1591: Improve the navigation by providing a vertical bar showing where you are, and where diffs are

lon***@gmai***** (Google Code) (Is this you? Claim this profile.)
March 21, 2011
1263 
board.org/
What version are you running?

1.5 Beta 1 (or 2)

What's the URL of the page this enhancement relates to, if any?

http://reviews.reviewboard.org/r/1276/diff/#index_header

Describe the enhancement and the motivation for it.

Improve the navigation by providing a vertical bar showing where you are, 
and more importantly, where diffs are.

For long reviews, or if you expand the files, it may be difficult to find 
the diffs.  You may scroll past them, or waste time locating them.

An example is what xdiffs does:
http://reality.sgiweb.org/rudy/xdiff/

A first step could to only provide a visual indication.  Either trough a
bar or some overview window.

A second time would be to make this click-able, so that you can immediately 
jump to the area of interest.

What operating system are you using? What browser?


Please provide any additional information below.

This would be complement of the hot keys (n, k) and the links RB already 
provides.

Google Chrome does a little bit of this for the search function with yellow 
markers in the scroll areas, but this is only visual.
chipx86
#1 chipx86 
We actually have this today, though it's not so obvious.

Click on a chunk to select that. It'll put a thick border around it.

Press spacebar to recenter on it.
#2 lon***@gmai***** (Google Code) (Is this you? Claim this profile.) 
I found a small issue ( http://reviews.reviewboard.org/r/1507/ ).

Though it's a cool feature, this is not what I was asking for.  The request is more
for a map to help orient oneself.  

It's only an example, but looking at:
http://www.google.com/support/chrome/bin/answer.py?hl=en&answer=95635

you can see the yellow markers in the scrollarea that give you a visual indication of
your current position in the diff view page.
chipx86
#3 chipx86 
Got it. Dunno when we'd do this but we can put it on the radar.
  • +Confirmed
  • +Component-DiffViewer
david
#4 david