1571: Diff-Upload UI: Base Path field too narrow

fbea*****@gmai***** (Google Code) (Is this you? Claim this profile.)
March 16, 2011
What version are you running?

What's the URL of the page containing the problem?
New Review Request (step 1)/Upload Diff

What steps will reproduce the problem?
1. click "New Review Request"
2. enter a Base Path value longer than ~50 chars

What is the expected output? What do you see instead?
Expected: to see all text that was entered.  Actual: only see a small
portion of what was entered.

What operating system are you using? What browser?
Windows/Mac OS X; Firefox 3.5+/Safari 3+

Please provide any additional information below.
There are at least two ways to fix this:  hack it in CSS; or improve the
markup for a more flexible layout.

The CSS hack involves something like:
.new_review_request div table { width : 100%; }
.new_review_request div table td:first_child { width : 150px; }

:: however the hack doesn't work when there's an error in the current UI
because the error is displayed in the third column and there's no way to
target that with CSS2 (CSS3 does support this but buggy support) ::

So, the current markup for the <form> in the "Upload DIFF" UI is like:
<div class="... new_review_request ...">
<td><!-- form field label i.e. 'Base Path' or 'Choose Repository'</td>
<td><!-- form field i.e. select, input text or file --></td>
<td><!-- blank - container for form submission errors --></td>

I recommend giving each TD above a class i.e. col-1, col-2, col-3 and then
set the width of each column in CSS.
#1 fbea*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Most of us use the browser's auto-complete feature for the base-path.  If this defect
is confirmed please leave the base path as a text field (as opposed to textarea) so
auto-complete is still possible.  We just want a wider text field (i.e. col-2 : 100%;
col-1 : 150px; col-3 : 250px; or something).
#2 chipx86
We'll continue to leave it as a text field. It's worth bumping the width though.
  • +Confirmed
  • -Priority-Medium
#4 chipx86
  • -Milestone-Release1.5
#5 chipx86
Hmm actually, I'm pretty sure we increased this for 1.5.
  • -Confirmed
  • +chipx86
#6 gorf****@gmai***** (Google Code) (Is this you? Claim this profile.)
Followed to this defect from Issue 1635

We have just upgraded to 1.5 the text width of the base directory and diff fields remains the same. Please see attached image.

#7 david
  • -Fixed
#9 KongM******@gmai***** (Google Code) (Is this you? Claim this profile.)
The situation has been changed a little bit:
1. When "choose file", it no longer shows the long path but exactly the filename.
2. But when the filename is long enough (~23), it shrinks. (see the attached image)
3. When path needs to be type in, it need scrolling.(up to 51 characters)

#10 gorf****@gmai***** (Google Code) (Is this you? Claim this profile.)
The base directory path can be significant in length, similarly file names are not so short either - who has filenames that are in 8.3 format any more? 

To me it made no sense that the 'base directory' and 'diff' fields where ever so small.

Please make it the full width of the display, it could at least match the length of the 'tip text' shown above.  The space being held in reserve for showing potential error could instead be displayed on the next 'row'.
#11 chipx86
They were small because we were using browser defaults for the sizes. Agreed, they should be longer. The presentation of the file field will greatly depend on the browser though. We have absolutely no say in that.
#12 david
Fixed in master (1.6) as a5a493e. Thanks!
  • -Confirmed