1530: Windows post-review documentation should tell how to install diff.exe

hbe****@gmai***** (Google Code) (Is this you? Claim this profile.)
March 29, 2010
769 
What version are you running?
0.2rc2

What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. Running on Windows XP, Python 2.6 installed -- followed instructions to 
get RBTools installed (easy_install)

2. post-review --server=http://server-id changelist

3. Recieve attached exception
C:\workspace\DEVELOPMENT\NOC 
GroundWork\MiddleTier\src\com\viasat\gw\middletier>post-review --
server=http://hbetts-lnx:8000/reviews/ 15149
Traceback (most recent call last):
  File "c:\programs\Python26\Scripts\post-review-script.py", line 8, in 
<module>
    load_entry_point('rbtools==0.2rc2.dev', 'console_scripts', 'post-
review')()
  File "build\bdist.win32\egg\rbtools\postreview.py", line 2777, in main
  File "build\bdist.win32\egg\rbtools\postreview.py", line 1451, in diff
  File "build\bdist.win32\egg\rbtools\postreview.py", line 1750, in 
_changenum_diff
  File "build\bdist.win32\egg\rbtools\postreview.py", line 1780, in 
_do_diff
  File "build\bdist.win32\egg\rbtools\postreview.py", line 2365, in execute
  File "c:\programs\Python26\lib\subprocess.py", line 621, in __init__
    errread, errwrite)
  File "c:\programs\Python26\lib\subprocess.py", line 830, in 
_execute_child
    startupinfo)
WindowsError: [Error 2] The system cannot find the file specified

What is the expected output? Success according to documentation
What do you see instead? above error


What operating system are you using? Windows XP
What browser? command line -- not browser issue


Please provide any additional information below.

I am new to python and may be missing something very easy, but this is 
important to our review and possible adoption of this product.
chipx86
#1 chipx86 
What type of repository is this against?

Can you run with --debug and show me the output?
  • +NeedInfo
#2 hbe****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Chip, Thanks.  Running against perforce.  I have attached the --debug.
  • +
    review-board_debug.txt 
    >>> p4 info
    >>> repository info: Path: vgasql01.hq.corp.viasat.com:2010, Base path: None, Supports changesets: True
    >>> Generating diff for changenum 15149
    >>> p4 describe -s 15149
    >>> Processing edit of //depot/DEVELOPMENT/NOC GroundWork/MiddleTier/src/com/viasat/gw/middletier/GWSync.java
    >>> Writing "//depot/DEVELOPMENT/NOC GroundWork/MiddleTier/src/com/viasat/gw/middletier/GWSync.java#6" to "c:\docume~1\hbetts\locals~1\temp\tmpyge5cq"
    >>> p4 print -o c:\docume~1\hbetts\locals~1\temp\tmpyge5cq -q "//depot/DEVELOPMENT/NOC GroundWork/MiddleTier/src/com/viasat/gw/middletier/GWSync.java#6"
    >>> Writing "//depot/DEVELOPMENT/NOC GroundWork/MiddleTier/src/com/viasat/gw/middletier/GWSync.java#7" to "c:\docume~1\hbetts\locals~1\temp\tmpa6mliu"
    >>> p4 print -o c:\docume~1\hbetts\locals~1\temp\tmpa6mliu -q "//depot/DEVELOPMENT/NOC GroundWork/MiddleTier/src/com/viasat/gw/middletier/GWSync.java#7"
    >>> diff -urNp c:\docume~1\hbetts\locals~1\temp\tmpyge5cq c:\docume~1\hbetts\locals~1\temp\t
chipx86
#3 chipx86 
You need GNU diff in your path. post-review requires this for diffing the files.

The one from here should work: http://gnuwin32.sourceforge.net/packages/diffutils.htm
  • -NeedInfo
    +SetupIssue
  • -Type-Defect
    +Type-Support
#4 hbe****@gmai***** (Google Code) (Is this you? Claim this profile.) 
That fixed the issue.  Better documentation of windows requirements would have 
prevented this.
chipx86
#5 chipx86 
Agreed.

In the future, we'll likely not need GNU diff, but for now...
  • -SetupIssue
    +Confirmed
  • -Type-Support
    -Priority-Medium
    +Type-Defect
    +Priority-High
    +Component-Docs
    +Milestone-Release1.5
  • +Windows post-review documentation should tell how to install diff.exe
david
#6 david