1494: post-review on windows vista/7 uses the wrong folder to store the authentication cookie, and it uses the diff command

gfb***@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 21, 2010
1279 
What version are you running?
0.2 beta2

post-review tries to use the %home folder% + Local Settings + Application
Data to store the authentication cookie. That folder doesn't exists on
windows vista or windows 7 so the script fails.

(I replaced that part with the value of the "APPDATA" environment variable
to make it run)

Another issue is that using it with a subversion repository it invokes svn
with a external diff command (--diff-cmd=diff). Again in windows that
external command is not available, and the internal svn diff implementation
can be used.

Kind Regards
Federico
chipx86
#1 chipx86 
Upgrade to RC1. This is fixed there.
  • +Fixed
  • +Component-RBTools
chipx86
#2 chipx86
#3 gfb***@gmai***** (Google Code) (Is this you? Claim this profile.) 
Thanks, I will upgrade
#4 gfb***@gmai***** (Google Code) (Is this you? Claim this profile.) 
RC1 fixed the application data issue, but not the external diff command
chipx86
#5 chipx86 
We use GNU diff instead of svn's built-in diff to work around some bugs. We won't be
changing that immediately, though in a future version I'm hoping we can bundle our
own diff as part of RBTools to prevent this problem.