1490: Screenshot comments appear empty

AaronJ*******@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 17, 2010
What version are you running? 1.0.5.1


What's the URL of the page containing the problem? Internal only (any
screenshot)


What steps will reproduce the problem?
1. Create a review with a screenshot
2. Select a region of the screenshot to review
3. Click "Edit review"

What is the expected output? What do you see instead?

I expect to see the thumbnail of the selected region of the image. Instead,
I see a text link. 


What operating system are you using? What browser?

Linux on both sides, tested under 32/64 bit OSes and with Firefox 3.5 and
recent versions of Chrome.


Please provide any additional information below.

Here's the HTML of the problematic link in the "edit review" popup:

 <div class="comments">
  <dl class="diff-comments">
   <dt>
    <div class="screenshot">
     <span class="filename">
      <a href="/r/121706/s/16785/">workstation preferences</a>
     </span>
     <img src="" alt="test" width="87" height="32">

Notice the src="" which should contain the URL of the thumbnail.

I checked to see if PIL was installed and being used. lsof says that the
running mod_python image has PIL libraries linked in. Permissions on disk
in the media area appear to be valid and new screenshots can be added by
users at any time.
david
#1 david
Fixed in djblets f1f87d3. Thanks!
  • +Fixed
#2 alex.k******@gmai***** (Google Code) (Is this you? Claim this profile.)
i am still seeing this issue but there is no src="" attribute

i am using Safari 5 on Mac OS 10.6 and RB 1.0.9