1402: post-review: list index out of range error when last diff file is empty

simon.******@gmai***** (Google Code) (Is this you? Claim this profile.)
Nov. 28, 2009
What version are you running? 1.1 alpha 2 (dev)


What's the URL of the page containing the problem?
[DomainName]/api/json/reviewrequests/[ReviewRequestId]/diff/new/

What steps will reproduce the problem?
1. post-review something that contains an empty diff as the last diff file.
E.g. __init__.py
2. The bug is caused in overloaded SVNDiffParser.parse_special_header function

What is the expected output? What do you see instead?
No exception and diff uploaded

What operating system are you using? What browser?
KUbuntu, Firefox

Please provide any additional information below.

I have a fix for this bug for all subclasses of DiffParser which overload
parse_special_header() and I'll post it to your reviewboard in due course.
david
#1 david
Fixed in revision d7d60a1.
  • +Fixed