1396: Screenshot comments not rendered correctly on 1.1

jahu****@nvidi***** (Google Code) (Is this you? Claim this profile.)
Nov. 23, 2009
What version are you running?
1.1 alpha 1, and 1.1 alpha 2 11/10/2009

What's the URL of the page containing the problem?

What steps will reproduce the problem?
1. Create a review
2. Add screenshots to review
3. Highlight area of a screenshot and make a comment call screenshot, 
e.g. "example".
4. Submit review, receive email.
5. Observe red-X under comment in email (Outlook 2007)
6. Click "example.jpg" - URL is bad (e.g. /r/10/s/15)
7. Return to review URL (e.g. http://myhostname/r/10/)
8. Observe (on IE) red-X under added comment (on FF) no image.

What is the expected output? What do you see instead?
Clicking on "example.jpg" should open browser
Expect to see image clips under screenshot comments

HTML rendered in browser:

   <dl class="diff-comments">

     <a name="scomment3"></a>
     <div class="screenshot">
      <span class="filename">
       <a href="/r/10/s/15/">example</a>
      <img src="" width="39" height="15" alt="Is there supposed to be a 
difference?" /> ********* observe img src=""
     <pre>Is there supposed to be a difference?</pre>

Nothing in log

What operating system are you using? What browser?
Client: IE7, Outlook2007, XP
Server: WS2003, Py2.5, Apache, mod_python
#1 chipx86
  • +Confirmed
  • -Priority-Medium
#2 chipx86
Fixed in Djblets (r37c13a9). You should be able to install a nightly and this problem
will go away.
  • -Confirmed
  • +Djblets
  • +chipx86