1393: uploading diff fails for bzr when containing changes to a renamed file

kro****@gmai***** (Google Code) (Is this you? Claim this profile.)
Nov. 12, 2009
What version are you running? and master

What's the URL of the page containing the problem?


What steps will reproduce the problem?
Unable to reproduce with a simple bzr branch. Working on that.
However, debugging shows that fileid is None in bzr.py.
Since bzr's fileid is created when the file is added and retained when renaming or moving files, 
the change proposed in http://reviews.reviewboard.org/r/1209/ is safe.

What is the expected output? What do you see instead?
Uploading a diff that contains changes to renamed files (all of them actually) fails with an 
SCMError exception.
Uploading should work, since the file is present, just renamed.

What operating system are you using? What browser?
Irrelevant, happens all the time.

Please provide any additional information below.
http://reviews.reviewboard.org/r/1209/ contains the proposed patch for this (works for both 
master and release-
#1 chipx86
Fixed on release-1.0.x and master (r7eb6cec).
  • +Fixed
  • +Component-SCMTools
  • +chipx86