Opening this bug per Christian Hammond.
What version are you running?
RBTools 0.2beta2
What's the URL of the page containing the problem?
n/a
What steps will reproduce the problem?
1. Don't have diff[.exe] in the path
2. Run a post-review
What is the expected output?
More friendly error reporting of the missing diff utility.
It should be pretty easy to detect "svn: Can't start process 'diff': The system
cannot find the file specified." and highlight that in the output (and ideally a
quick "Check your PATH" hint).
What do you see instead?
>>> svn info
>>> repository info: Path: svn://devsrvsea01/svnroot, Base path:
/trunk/StopProcess, Supports changesets: False
>>> svn propget reviewboard:url C:\src\trunk\StopProcess
>>> svn propget reviewboard:url C:\src\trunk\
>>> svn diff --diff-cmd=diff -r 24506
Failed to execute command: ['svn', 'diff', '--diff-cmd=diff', '-r',
'24506']
['Index: StopProcess/obj/Debug/StopProcess.exe\n',
'===================================================================
\n', 'Cannot display: file marked as a binary type.\n', 'svn:mime-type
=
application/octet-stream\n', 'Index: StopProcess/obj/Debug/
StopProcess.pdb\n',
'===================================================================
\n', 'Cannot display: file marked as a binary
type.\n', 'svn:mime-type = application/octet-stream\n', 'Index:
StopProcess/obj/Debug/StopProcess.csproj.FileListAbsolute.txt\n',
'============================================================
=======\n', "svn: Can't start process 'diff': The system cannot find
the file specified. \n"]
What operating system are you using? What browser?
n/a
Please provide any additional information below.
n/a
