1353: Change selection frame sticks to screen position when expanding unchanged lines

Oliver******@gmai***** (Google Code) (Is this you? Claim this profile.)
Oct. 13, 2009
What version are you running?

What's the URL of the page containing the problem?
internal system: view diffs 

What steps will reproduce the problem?
1. Find a review request with collapsed lines above the first diff.
2. Go to "View Diff"
3. Select the first diff by clicking on it; a rectangular frame will appear
around it.
4. Expand collapsed text above the change.

What is the expected output? What do you see instead?

I would expect that the frame indicating the selected diff moves down the
page with the diff. Instead the frame stays on the screen position where
the diff was before expanding the hidden lines.

What operating system are you using? What browser?
OS: Windows XP
Browser: Firefox 3.5.3

Please provide any additional information below.
I just checked the issue with Internet Explorer 7.0.5730.13, and there it
does not occur: instead the frame moved with the selected diff as expected.
#1 chipx86
Fixed on master and release-1.0.x (rddfc9bd)
  • +Fixed
  • +Component-DiffViewer
  • +chipx86