1192: post-review didn't update an existing review request for a changeset

jameslin
Sept. 23, 2009
What version are you running?


What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. So because of issue 1191, I tried to use "post-review -r reviewID
changeset" to reuse the empty draft. (Note that doing so didn't copy the
summary/description from my changeset.  I ended up copying/pasting it
manually.)
2. Later on I ran "post-review changeset".


What is the expected output? What do you see instead?
After step 2, I ended up with a second review request draft for the same
changeset number.


What operating system are you using? What browser?
Red Hat 9

Please provide any additional information below.
#1 jameslin
Ah, I see.  When I did step 1, my new review request didn't actually have a Perforce
changeset number associated with it (it says Change Number: None), so I suppose it
goes along with the part about it not copying any of the information over.
chipx86
#2 chipx86
Yeah, without a change number, we can't copy any information.

Sounds like just an issue with that particular change. This one doesn't seem to be a bug.
  • +NotABug
#3 jameslin
But why didn't it get a change number when I did "post-review -r reviewID changeset"?
david
#4 david
Fixed for real in rbtools 65eec92.
  • -NotABug
    +Fixed