What version are you running? chipx86 says 1.0RC3. What's the URL of the page containing the problem? What steps will reproduce the problem? 1. Create a review that includes adds or edits to binary files. 2. View the diff. What is the expected output? What do you see instead? The binary files are listed among the "Files changed" momentarily with throbber icons, but after they're fetched, they're removed. Although we can't show diffs of binary files, listing them (and showing whether they're added, deleted, or edited) is important. (How else can you know if someone forgot to include a required binary file in their change?) What operating system are you using? What browser? Windows XP x64 SP2, Firefox 3.0.11 Please provide any additional information below.
That seems to be the problem. We should get this in for 1.0.5.
+ Milestone-Release1.0.x + Component-DiffViewer
- Priority-Medium + Priority-High
Fixed in master (reb80a58) and release-1.0.x (reb80a58)
- Confirmed + Fixed
Hm, so it looks like binary files now show up, but AFAICT there's no indication whether they're added/edited/deleted.