1165: diffviewer does not show all comments (RC2)

ochern*******@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 6, 2010
1270, 1440
What version are you running?

What's the URL of the page containing the problem?
RB in local enterprise network.

What steps will reproduce the problem?
1. Hmmmm. The issue is same as described in #1028. But file on review is
much bigger. 

What is the expected output? What do you see instead?
Comments on little blocks of diffs are shown. If a diff is big, comment is
now shown.

What operating system are you using? What browser?
Firefox 3. RB hosted on FC4. 

Please provide any additional information below.
#1 chipx86
Do these comments begin/end in otherwise collapsed regions?

While I've seen two reports of this, I have not seen a single repro case we can use
to work with. We would need a patch and list of comments with their beginning/ending
lines in order to debug this.
  • +NeedInfo
#2 ochern*******@gmai***** (Google Code) (Is this you? Claim this profile.)
What means collapsed regions?

Patch is attached
I've attached three screenshots. Look at them.
Comments can be seen on screenshot_3.jpg.

Based on patch you can create repro case.
  • +
    Index: ColorSB.c
    RCS file: /cvsroot/openmotif/openmotif/lib/Xm/ColorSB.c,v
    retrieving revision 1.14
    diff -u -b -B -w -r1.14 ColorSB.c
    --- ColorSB.c	13 May 2009 15:12:45 -0000	1.14
    +++ ColorSB.c	12 Jun 2009 11:58:02 -0000
    @@ -140,6 +140,11 @@
     static XtGeometryResult GeometryHandler(Widget, XtWidgetGeometry*, XtWidgetGeometry*);
     static XtGeometryResult QueryGeometry(Widget, XtWidgetGeometry*, XtWidgetGeometry*);
    +static Dimension CalcMatrixBoard(Widget);
    +static Dimension CalcRGBLabelWidth(Widget);
    +static Dimension CalcHSVLabelWidth(Widget);
    +static void ResizeMatrixBoard(Widget);
     static void CalcPreferredSize(XmColorSelectionBoxWidget, Dimension*, Dimension*);
     static void CreateColorPaletteWindow(XmColorSelectionBoxWidget, ArgList, Cardinal);
     static void CreateColorMatrixWindow(XmColorSelectionBoxWidget, ArgList, Cardinal);
    @@ -611,6 +616,100 @@
     	return FALSE;
    +static Dimension
#3 ochern*******@gmai***** (Google Code) (Is this you? Claim this profile.)
#4 ochern*******@gmai***** (Google Code) (Is this you? Claim this profile.)
To make a repo case use the following data:
repository Path: :pserver:anonymous@openmotif.cvs.sourceforge.net:/cvsroot/openmotif
Username: anonymous
Tool: CVS
#5 david
  • -NeedInfo
#8 lon***@gmai***** (Google Code) (Is this you? Claim this profile.)
see http://reviews.reviewboard.org/r/1308/
#9 david
Fixed in master rev f7778d4.
  • -New