1162: post-review ignores all but first target file when using --revision-changes

ssy****@gmai***** (Google Code) (Is this you? Claim this profile.)
Sept. 27, 2009
What version are you running?

CentOS 5.3
Review Board 1.0 RC2
post-review 0.8
SVN repository

What steps will reproduce the problem?
1. Make changes to three different files, A.java, B.java, and C.java, in
the same package. Say this is revision 10. Make other changes to repository
if desired.
2. Call 'post-review --revision-range=9 --repository-url=[URL]
package/A.java package/B.java'

What is the expected output? What do you see instead?

A review request diff with only changes to the files A.java and B.java.
Instead the diff only has changes to file A.java.

Please provide any additional information below.

When --revision-range is not used, post-review works as expected.
#1 david
Fixed in 6085ed1. Thanks!
  • +Fixed
#2 cpfo****@gmai***** (Google Code) (Is this you? Claim this profile.)
The case where --repository-url=url is not specified is not handled.
the do_diff call on line 1137 also needs the files added to the command.