What version are you running? RBTools 0.2beta1 What's the URL of the page containing the problem? N/A What steps will reproduce the problem? 1. "svn delete <some_file>" 2. "svn commit -m 'deleting a file'" 3. "post-review --revision-range=<revision-1>:<revision>" What is the expected output? What do you see instead? Expected: login prompt Actual: Failed to execute command: ['svn', 'info', '<path>/<deleted_file>'] ["svn: '<path>/<deleted_file>' is not under version control\n"] What operating system are you using? What browser? OS X Please provide any additional information below. Manually posting a diff to a ReviewBoard website that includes a deleted file works fine in the latest version, but the post-review tool does not work.
I added a workaround for that issue on my local installation. I hope it can help anybody having the same problem until an official fix come out. Attached are two files: - postreview.org is the original one upon which the fix is based (RBTools-0.2) - postreview.py is the modified one that handles the case of deleted files.
We need fixes submitted to reviews.reviewboard.org, not posted here (especially in the format that it was). The code in post-review has also diverged a lot since 0.2.
I ran into this problem recently. I understand that you have an established workflow but this is a nasty bug that cost more than a few of us time. I don't know your code base, but was successfully (easily) able to port the files from above (0.2 to 0.3.4). I'm going to attach my diff from 0.3.4, if you really need me to apply it to reviews.reviewboard.org I can, but it seems like you should be able to do it more quickly. I really hope this gets incorporated into future versions as it is quite annoying.
I've refactored the patch to apply to 0.4.x and it's up for review: http://reviews.reviewboard.org/r/2932/
Fixed in master (f226c46). Thanks!
- PendingReview + Fixed