1071: Review Board does not handle files with ^M characters at end of line.

ragh****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
chipx86
May 28, 2009
Review Board does not handle files with ^M characters at end of line.

What steps will reproduce the problem?
1. The setup is a review board server using a perforce repository
2. Create a changelist that contains at least one file with ^M characters
at end of line - i.e. \r\r\n patterns at end of line.
3. Use post-review to send it to review board.
4. Attempt to view the diff. You get a traceback.

What is the expected output? What do you see instead?
There should not be any stack trace, instead I get an error:
The patch to '%s' didn't apply cleanly. The temporary files have been left
in '%s' for debugging purposes.

I have a patch for this submitted for review.
chipx86
#1 chipx86
Committed as r1988.
  • +Fixed
  • -Priority-Medium
    +Priority-High
    +Milestone-Release1.0
    +Component-DiffViewer
    +Component-RBTools
  • +chipx86