1050: Screenshot Comment location issue with Chrome

anv***@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
Oct. 9, 2009 
What's the URL of the page containing the problem?
http://reviewboard.site.com/r/revision-number/s/screenshot-number/

What steps will reproduce the problem?
1. In Chrome, create a screenshot comment
2. Save your review
3. Look at the comment in any other browser, or in a different window size 
of chrome

What is the expected output? What do you see instead?
The screenshot location should be based on the image itself, currently it 
looks like the location is purely based on where the box was in the browser 
window itself when it was created - thus those viewing the screenshot 
comment will not see it in the correct location.

In addition, if you create a screenshot comment in, say, FireFox and then 
look at it in chrome, you'll notice that the same problem occurs (the 
comment isn't where it is supposed to be)

What operating system are you using? What browser?
WinXP - Chrome - This appears to be a problem with Chrome and ReviewBoard.

Please provide any additional information below.
Djblets-0.5beta2.dev_20090415-py2.4.egg
ReviewBoard-1.0beta3.dev_20090415-py2.4.egg
chipx86
#1 chipx86 
For the time-being, we're not officially supporting Chrome, as it has a lot of
rendering issues with various things (and it's not just us). I'll look into it though.
  • +Confirmed
  • -Priority-Medium
    +Priority-Low
    +Milestone-Release1.0
    +Component-Screenshots
    +Browser
#2 anv***@gmai***** (Google Code) (Is this you? Claim this profile.) 
The problem looks like it is in the .position function found in jquery - a file 
that's extremely difficult to look at or tweak...

Looks like it is fixed in jquery 1.3.3 (which isn't released yet)
http://dev.jquery.com/ticket/4263
chipx86
#3 chipx86 
We'll take the fix if jQuery 1.3.3 comes out before our 1.0, and doesn't cause any
serious regressions like 1.3.2 did. We may end up postponing this to a 1.0.x release,
if we need to.
#4 anv***@gmai***** (Google Code) (Is this you? Claim this profile.) 
Yea, i spoke too soon - the change I linked to fixes something else (i tested it 
later last night).

If I get time later this week I'll look into making a patch for jquery as well as for 
RB's jquery1.3.2mini
chipx86
#5 chipx86 
That would be nice, but I'm not going to hold my breath that we'll fix this without
regressions right now. Going to push back to 1.5. If you do fix it, let us know and
we'll consider the fix for 1.0.
  • -Milestone-Release1.0
    +Milestone-Release1.5
#6 Ari***@gmai***** (Google Code) (Is this you? Claim this profile.) 
I have the same problem with Safari 4.
chipx86
#7 chipx86
  • -Milestone-Release1.5
    +Milestone-Release1.0.x
chipx86
#8 chipx86 
Fixed in 1.0.4.
  • -Confirmed
    +Fixed
  • +chipx86